bito-code-review[bot] commented on code in PR #35859:
URL: https://github.com/apache/superset/pull/35859#discussion_r2890695826
##########
superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.ts:
##########
@@ -167,15 +220,13 @@ function CountryMap(element: HTMLElement, props:
CountryMapProps) {
const mouseenter = function mouseenter(this: SVGPathElement, d: GeoFeature) {
// Darken color
let c: string = colorFn(d);
- if (c !== 'none') {
+ if (c && c !== 'none') {
c = d3.rgb(c).darker().toString();
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Obsolete condition in hover darkening</b></div>
<div id="fix">
The check for 'none' in the mouseenter handler is obsolete since colorFn now
returns '#d9d9d9' instead of 'none' for missing data. This could cause the
fallback gray to be incorrectly darkened on hover, altering the visual behavior.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
let c: string = colorFn(d);
if (c && c !== '#d9d9d9') {
c = d3.rgb(c).darker().toString();
````
</div>
</details>
</div>
<small><i>Code Review Run #93546d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
