hainenber commented on code in PR #38155:
URL: https://github.com/apache/superset/pull/38155#discussion_r2890386557
##########
.github/workflows/pre-commit.yml:
##########
@@ -61,11 +61,17 @@ jobs:
restore-keys: |
pre-commit-v2-${{ runner.os }}-py${{ matrix.python-version }}-
+ - name: Get changed files
+ id: changed_files
+ uses: ./.github/actions/file-changes-action
+ with:
+ output: ' '
+
- name: pre-commit
run: |
set +e # Don't exit immediately on failure
- export SKIP=eslint-frontend,type-checking-frontend
- pre-commit run --all-files
+ export SKIP=type-checking-frontend
Review Comment:
[`eslint-frontend` is no more
there](https://github.com/apache/superset/blob/master/.pre-commit-config.yaml#L70-L97),
fellas. It has been replaced by `oxlint-frontend` in pre-commit config.
For eslint rules not yet ported to oxlint, we do have
[`custom-rules-frontend` pre-commit that is not
skipped](https://github.com/apache/superset/blob/master/.pre-commit-config.yaml#L78).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
