piopy opened a new pull request, #38443: URL: https://github.com/apache/superset/pull/38443
Fixes #38442 The existing assert_called_with assertions in test_validate_parameters_catalog and test_validate_parameters_catalog_and_credentials were updated to reflect the corrected call signature. The previous assertions were inadvertently testing the broken behavior. <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY When using Google Sheets with service account authentication, the connection fails because `service_account_info` is passed as a top-level keyword argument to `create_engine()` instead of being nested under `connect_args → adapter_kwargs → gsheetsapi`, as required by shillelagh. This affects both `update_params_from_encrypted_extra` and `validate_parameters`. Solution: - In `update_params_from_encrypted_extra`: wrap `service_account_info` and `catalog` inside `connect_args.adapter_kwargs.gsheetsapi` - In `validate_parameters`: use `connect_args={"adapter_kwargs": {"gsheetsapi": {...}}}` instead of top-level kwargs in `create_engine()` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Uploaded in [Issue 38442](https://github.com/apache/superset/issues/38442) ### TESTING INSTRUCTIONS Verified manually with Superset 6.0.0 deployed via Docker Compose with a Google service account JSON credential + pytest ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #38442 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
