Copilot commented on code in PR #38193:
URL: https://github.com/apache/superset/pull/38193#discussion_r2885435804
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx:
##########
@@ -625,6 +625,7 @@ const FilterControls: FC<FilterControlsProps> = ({
: undefined
}
forceRender={hasRequiredFirst}
+ alwaysShowDropdownButton={items.length > 0}
ref={popoverRef}
Review Comment:
Passing `alwaysShowDropdownButton={items.length > 0}` will show the “More
filters” trigger even when there are no overflowed/out-of-scope items (i.e.
`dropdownContent` is `undefined`). That can result in a “More filters” button
with no popover content (and also reduces available horizontal space,
potentially forcing extra overflow). If the goal is only to avoid flicker
during intermediate layout recalculation, consider enabling this only while
overflow detection is pending, or ensure the dropdown always has meaningful
content / the trigger is disabled when there’s nothing to show.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
