aminghadersohi opened a new pull request, #38373:
URL: https://github.com/apache/superset/pull/38373

   ### SUMMARY
   
   Makes `dashboard_title` optional in the `generate_dashboard` MCP tool. When 
no title is provided, a descriptive one is built from the included chart names:
   
   - 1 chart: `"Revenue"`
   - 2 charts: `"Revenue & Costs"`
   - 3 charts: `"Revenue, Costs, Profit"`
   - 4+ charts: `"Revenue, Costs, Profit + 2 more"`
   
   Titles longer than 150 characters are truncated with an ellipsis. Falls back 
to `"Dashboard"` when no chart has a usable name.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A — backend/API change only.
   
   ### TESTING INSTRUCTIONS
   
   1. Call `generate_dashboard` with `chart_ids` but **without** 
`dashboard_title`
   2. Verify the created dashboard title is derived from the chart slice names
   3. Call `generate_dashboard` with an explicit `dashboard_title` — behavior 
unchanged
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to