imad-hl commented on issue #37853: URL: https://github.com/apache/superset/issues/37853#issuecomment-3991871998
> PR opened... please review and see if it fixes the issue. This fix is different and addresses the actual root cause. Dosu's suggestion is about memoizing eventHandlers in EchartsTimeseries to prevent unnecessary setOption calls. That could be a performance optimization, but it doesn't fix the core problem. > > The real issue is simpler and more fundamental: filterState (which carries selectedValues) was completely dropped from the prop chain during the JSX→TSX conversion. Without it, chart plugins never receive any cross-filter selection state at all — no amount of event handler memoization can fix that. > > To put it concretely: > > * Dosu's fix: Stabilizes event handler references to avoid extra re-renders > * PR fix: Restores the missing data pipe (filterState) that tells charts which values are selected You're right about the root cause. However, there's a TypeScript error in the PR #38349. The added Line 764 in **_superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.tsx_** passes **filterState** to ChartContainer, but it's not defined in **ChartProps** in **_superset-frontend/src/components/Chart/Chart.tsx_**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
