sha174n opened a new pull request, #38357: URL: https://github.com/apache/superset/pull/38357
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR enhances the reliability and performance of Row Level Security (RLS) management by standardizing the command lifecycle and upgrading the SQL parsing engine for filter clauses. Key Changes: * Refined SQL Parsing: Implemented a recursive AST walker within the SQL parsing utility. This ensures that unsupported SQL patterns (such as nested subqueries) are reliably identified across complex expressions, improving parsing accuracy. * Management Layer Standardization: Refactored CreateRLSRuleCommand and UpdateRLSRuleCommand to utilize modern BaseCommand and DAO patterns. Validation logic has been centralized into a dedicated helper (validate_rls_clause) to ensure consistency across the management API. * Performance Optimization: Relocated filter validation from the runtime query generation path (models.py) to the management layer. By validating clauses only at creation or update time, we eliminate redundant parsing overhead from the critical path of dashboard execution. * Enhanced API Feedback: Improved REST API error handling to provide granular feedback. When unsupported SQL fragments are detected, the API now returns clear, actionable 422 errors instead of generic system failures. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
