rusackas opened a new pull request, #38349: URL: https://github.com/apache/superset/pull/38349
### SUMMARY PR #37625 converted the dashboard grid `Chart` component from JSX to TSX. During this conversion, the `filterState` prop was accidentally dropped from the `<ChartContainer>` render call. This prop passes `dataMask[chartId].filterState` (which contains `selectedValues`) from the Redux store down to chart plugins via `ChartContainer` → `Chart` → `ChartRenderer` → `SuperChart` → plugin `transformProps`. Every ECharts chart relies on `filterState.selectedValues` to: - **Highlight selected data** via ECharts `highlight`/`downplay` actions - **Dim non-selected series** via opacity changes in `transformProps` - **Track selection state** for cross-filter toggling (click to select, click again to deselect) Without this prop, all three cross-filter behaviors are broken, matching the symptoms reported in #37853. The fix is a one-line restoration of the dropped prop. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — restores behavior shown in the "Before" GIF of #37853. ### TESTING INSTRUCTIONS 1. Create a dashboard with charts that support cross-filtering (e.g., bar charts, pie charts) 2. Enable cross-filtering 3. Click on a data point — it should highlight and dim non-selected data 4. Click the same data point again — the cross-filter should toggle off 5. Right-click on a data point — should open context menu without retriggering animations ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #37853 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
