madhushreeag commented on code in PR #38117:
URL: https://github.com/apache/superset/pull/38117#discussion_r2835144902
##########
superset-frontend/src/explore/components/controls/TextAreaControl.tsx:
##########
@@ -174,6 +174,22 @@ class TextAreaControl extends
Component<TextAreaControlProps> {
});
});
};
+ // Exclude props that shouldn't be passed to TextAreaEditor
+ // - theme: TextAreaEditor expects theme as a string, not the theme
object from withTheme HOC
+ // - height: ReactAce expects string, we pass number (height is
controlled via minLines/maxLines)
+ // - other control-specific props that ReactAce doesn't need
+ const {
+ theme,
+ height,
+ offerEditInModal,
+ aboveEditorSection,
+ resize,
+ textAreaStyles,
+ tooltipOptions,
+ hotkeys,
+ debounceDelay,
Review Comment:
Fixed in the latest commit — language, initialValue, readOnly, name,
onChange, minLines, and maxLines are now all destructured out before the
spread, eliminating the duplicate prop assignments. The
destructuring was also moved to the top of renderEditor so the rest of the
method uses local variables consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
