bito-code-review[bot] commented on code in PR #38115:
URL: https://github.com/apache/superset/pull/38115#discussion_r2832552463
##########
superset-frontend/plugins/legacy-plugin-chart-rose/src/Rose.ts:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
// @ts-nocheck
-/* eslint no-use-before-define: ["error", { "functions": false }] */
+/* oxlint-disable no-use-before-define: ["error", { "functions": false }] */
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Invalid oxlint disable syntax</b></div>
<div id="fix">
The updated comment uses invalid syntax for oxlint, which doesn't support
inline rule configuration with options like ESLint does. This could cause
linting failures if the file violates the no-use-before-define rule.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset-frontend/plugins/legacy-plugin-chart-rose/src/Rose.ts
+++ superset-frontend/plugins/legacy-plugin-chart-rose/src/Rose.ts
@@ -20,1 +20,1 @@
-/* oxlint-disable no-use-before-define: ["error", { "functions": false }]
*/
+/* oxlint-disable no-use-before-define */
```
</div>
</details>
</div>
<small><i>Code Review Run #ef69a1</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
