rusackas commented on PR #34742: URL: https://github.com/apache/superset/pull/34742#issuecomment-3876242712
## Bot Review Comments Addressed I've pushed a commit that addresses all the bot review feedback: ### Already addressed in previous commits: - **Copilot**: Redundant `|| 0.001` fallback removed ✅ - **Copilot**: Changed `Math.ceil` to `Math.round` for balanced step sizes ✅ ### Fixed in latest commit: - **codeant-ai (test)**: Added `await` to all `userEvent` calls to prevent flaky test behavior ✅ - **codeant-ai (step calculation)**: Simplified `calculateStep` to avoid floating-point string parsing issues (e.g., `0.07-0.05` producing `0.020000000000000004`) ✅ - **bito**: Unified the step calculation logic - now uses the same consistent approach (range/100 steps with nice number rounding) for all ranges ✅ The simplified approach: 1. Handles all ranges consistently (small decimals, large numbers, negatives) 2. Avoids floating-point string parsing pitfalls 3. Always produces approximately 100 steps with "nice" values (0.0001, 0.001, 0.01, 0.1, 1, 10, etc.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
