rusackas commented on code in PR #33247:
URL: https://github.com/apache/superset/pull/33247#discussion_r2775590023
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Geojson/controlPanel.ts:
##########
@@ -343,15 +345,56 @@ const config: ControlPanelConfig = {
},
],
[
+ {
+ name: 'point_radius',
+ config: {
+ type: 'SelectControl',
+ freeForm: true,
+ label: t('Point Radius'),
+ description: t(
+ 'The radius of point features, in the units specified below. '
+
+ 'The final rendered size is this value multiplied by Point
Radius Scale.',
+ ),
+ validators: [validateInteger],
+ default: 10,
+ choices: formatSelectOptions([1, 5, 10, 20, 50, 100]),
+ renderTrigger: true,
+ },
+ },
{
name: 'point_radius_scale',
config: {
type: 'SelectControl',
freeForm: true,
label: t('Point Radius Scale'),
- validators: [legacyValidateInteger],
- default: null,
- choices: formatSelectOptions([0, 100, 200, 300, 500]),
+ description: t(
+ 'A multiplier applied to the point radius. ' +
+ 'Use this to uniformly scale all points.',
+ ),
+ validators: [validateNumber],
+ default: 1,
+ choices: formatSelectOptions([0.1, 0.5, 1, 2, 5, 10]),
+ renderTrigger: true,
+ },
+ },
+ ],
+ [
+ {
+ name: 'point_radius_units',
+ config: {
+ type: 'SelectControl',
+ label: t('Point Radius Units'),
+ description: t(
+ 'The unit for point radius. Use "pixels" for consistent ' +
+ 'screen-space sizing regardless of zoom level.',
+ ),
+ default: 'pixels',
Review Comment:
This is now defaulted to pixels, i think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]