bito-code-review[bot] commented on code in PR #37441:
URL: https://github.com/apache/superset/pull/37441#discussion_r2772726485
##########
superset-frontend/packages/superset-ui-core/test/time-comparison/parseDttmToDate.test.ts:
##########
@@ -69,7 +69,7 @@ test('should return the current date for "today"', () => {
'today',
NOW_UTC_IN_EUROPE,
'Etc/GMT-2',
- new Date('2024-06-03T00:00:00+02:00'),
+ new Date('2024-06-01T22:00:00Z'),
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect Test Expectations</b></div>
<div id="fix">
The updated test expectations for the Europe timezone do not match the
parseDttmToDate function's behavior. For example, 'today' should return local
midnight in the mocked timezone (2024-06-03T00:00:00+02:00), not
2024-06-01T22:00:00Z. Revert these changes to ensure tests validate correct
logic.
</div>
</div>
<small><i>Code Review Run #406b0a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
