rusackas opened a new pull request, #37715:
URL: https://github.com/apache/superset/pull/37715

   ### SUMMARY
   
   **Adopted from #33940 - Originally by @rusackas**
   
   This PR adopts and applies the core feature from #33940: making label 
position options in the Radar chart translatable.
   
   **Changes:**
   - Wrap Radar chart label position strings with `t()` for translation support
   - Move the `LABEL_POSITION` constant from `constants.ts` to a local 
`getLabelPositionOptions()` function in `controlPanel.tsx`
   - Remove the unused `LabelPositionEnum` import from `constants.ts`
   
   **Note about translations update:** The original PR (#33940) also included a 
batch update of all translation `.po/.pot` files. Per user guidance, the 
translation file conflicts should accept upstream/master versions, so this PR 
focuses only on the code changes that enable the new translatable strings. The 
translation files will be automatically updated during the next translation 
extraction cycle.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A - No visual changes. The label position dropdown will display the same 
strings, but they will now be translatable.
   
   ### TESTING INSTRUCTIONS
   
   1. Navigate to a Radar chart in Explore view
   2. Open the "Chart Options" section
   3. Find the "Label position" dropdown
   4. Verify the dropdown still displays all label position options (Top, Left, 
Right, Bottom, Inside, Inside left, etc.)
   5. If running with a non-English locale, verify the label positions are now 
translated
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: Fixes #29479
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ---
   
   Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to