aminghadersohi commented on code in PR #37411:
URL: https://github.com/apache/superset/pull/37411#discussion_r2771238584
##########
tests/unit_tests/sql/parse_tests.py:
##########
@@ -2942,6 +2942,39 @@ def test_check_functions_present(sql: str, engine: str,
expected: bool) -> None:
assert SQLScript(sql, engine).check_functions_present(functions) ==
expected
[email protected](
+ "sql, engine, expected",
Review Comment:
Both string (`"sql, engine, expected"`) and tuple (`("sql", "engine",
"expected")`) formats are valid pytest parametrize syntax. The string format is
used consistently throughout this file (e.g., lines 835, 1011, 1024, etc.), so
I'm keeping it to match the existing convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
