rusackas commented on code in PR #37625:
URL: https://github.com/apache/superset/pull/37625#discussion_r2770064217
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx:
##########
@@ -572,15 +692,15 @@ export class TableRenderer extends Component {
) : null;
const needToggle =
- colSubtotalDisplay.enabled && attrIdx !== colAttrs.length - 1;
+ !!colSubtotalDisplay.enabled && attrIdx !== colAttrs.length - 1;
Review Comment:
Good catch — will remove the cast and check if the type is already boolean.
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx:
##########
@@ -773,15 +903,15 @@ export class TableRenderer extends Component {
<tr key="rowHdr">
{rowAttrs.map((r, i) => {
const needLabelToggle =
- rowSubtotalDisplay.enabled && i !== rowAttrs.length - 1;
+ !!rowSubtotalDisplay.enabled && i !== rowAttrs.length - 1;
Review Comment:
Good catch — will remove the cast and check if the type is already boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
