msyavuz commented on code in PR #36996:
URL: https://github.com/apache/superset/pull/36996#discussion_r2707580036
##########
superset-frontend/src/explore/components/controls/DateFilterControl/tests/DateFilterLabel.test.tsx:
##########
@@ -93,3 +93,40 @@ test('Open and close popover', () => {
expect(defaultProps.onClosePopover).toHaveBeenCalled();
expect(screen.queryByText('Edit time range')).not.toBeInTheDocument();
});
+
+test('DateFilter popover should attach to document.body when not overflowing',
() => {
+ render(setup({ ...defaultProps, isOverflowingFilterBar: false }));
+
+ userEvent.click(screen.getByText(NO_TIME_RANGE));
+
+ const popover = document.querySelector('.time-range-popover');
+ expect(popover?.parentElement).toBe(document.body);
+});
+
+test('DateFilter popover should attach to parent node when overflowing in
filter bar', () => {
+ render(setup({ ...defaultProps, isOverflowingFilterBar: true }));
+
+ userEvent.click(screen.getByText(NO_TIME_RANGE));
+
+ const popover = document.querySelector('.time-range-popover');
+ const trigger = screen.getByTestId(DateFilterTestKey.PopoverOverlay);
+
+ expect(popover?.parentElement).toBe(trigger.parentElement);
+});
+
+test('DateFilter should properly handle isOverflowingFilterBar prop changes',
() => {
+ const { rerender } = render(
+ setup({ ...defaultProps, isOverflowingFilterBar: false }),
+ );
+
+ userEvent.click(screen.getByText(NO_TIME_RANGE));
+ const popover = document.querySelector('.time-range-popover');
+ expect(popover?.parentElement).toBe(document.body);
+
+ userEvent.click(screen.getByText('CANCEL'));
+
+ rerender(setup({ ...defaultProps, isOverflowingFilterBar: true }));
+ userEvent.click(screen.getByText(NO_TIME_RANGE));
+
+ expect(defaultProps.onOpenPopover).toHaveBeenCalled();
Review Comment:
Is this checking the right thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
