codeant-ai-for-open-source[bot] commented on PR #37025: URL: https://github.com/apache/superset/pull/37025#issuecomment-3731152729
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37025/files#diff-b3064963d3cd4f003e1fdd175eb67153ed57841be8a74d5b7471974ae6782d78R100-R101'><strong>Handler-scoped watch roots</strong></a><br>The handler currently has no knowledge of which extension roots are being watched; it only inspects the event path. To correctly validate that a `dist` change belongs to a watched extension, propagate the watched roots into the handler (or attach them to the handler instance) and validate the event path relative to those roots.<br> - [ ] <a href='https://github.com/apache/superset/pull/37025/files#diff-b3064963d3cd4f003e1fdd175eb67153ed57841be8a74d5b7471974ae6782d78R49-R51'><strong>Cross-platform path check</strong></a><br>The new filter uses a literal string check "/dist/" on `event.src_path`. This is brittle on non-POSIX platforms (Windows uses backslashes) and can miss matches or produce false negatives. Prefer using Path-based checks that work with platform-specific separators.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
