GitHub user dosubot[bot] added a comment to the discussion: How to Mask
Passwords in Superset Action Log (DatabaseRestApi.import_)
<!-- Answer -->
Your current masking code is safe and will not skip any log entries. By
applying `_mask_sensitive` to `kwargs` before passing them to `super().log()`,
you ensure that all records—including bulk scenarios where `records` is a
list—are masked and logged as expected. Superset's logger processes the
`records` list internally, and your recursive masking covers all nested dicts
and lists, so you don't need to handle `records` separately unless you want to
inspect or print them before logging.
As long as your masking function preserves the structure and type of the
payload (especially lists under `records`), all logs will be created correctly.
The only limitation is that secrets inside stringified JSON fields (e.g.,
`"passwords": "{\"db\": \"secret\"}"`) won't be masked by this approach, but
this does not cause skipped logs—just unmasked secrets if present.
Your implementation is efficient and matches Superset's logging requirements
for both single and bulk events.
<!-- Dosu Comment Footer -->
*To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
---
<sup>How did I do?
[Good](https://app.dosu.dev/response-feedback/37fae701-3f3f-417b-8b31-6453d45293b2?feedback_type=great_response)
|
[Irrelevant](https://app.dosu.dev/response-feedback/37fae701-3f3f-417b-8b31-6453d45293b2?feedback_type=irrelevant_answer)
|
[Incorrect](https://app.dosu.dev/response-feedback/37fae701-3f3f-417b-8b31-6453d45293b2?feedback_type=incorrect_sources)
|
[Verbose](https://app.dosu.dev/response-feedback/37fae701-3f3f-417b-8b31-6453d45293b2?feedback_type=too_verbose)
|
[Hallucination](https://app.dosu.dev/response-feedback/37fae701-3f3f-417b-8b31-6453d45293b2?feedback_type=hallucination)
| [Report
🐛](https://app.dosu.dev/response-feedback/37fae701-3f3f-417b-8b31-6453d45293b2?feedback_type=bug_report)
|
[Other](https://app.dosu.dev/response-feedback/37fae701-3f3f-417b-8b31-6453d45293b2?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github)&
nbsp;[](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/discussions/35415)
GitHub link:
https://github.com/apache/superset/discussions/35415#discussioncomment-14580826
----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
