mistercrunch commented on code in PR #35042:
URL: https://github.com/apache/superset/pull/35042#discussion_r2328416771
##########
superset/utils/core.py:
##########
@@ -1858,6 +1859,112 @@ def get_legacy_time_column(
)
+def detect_datetime_format(series: pd.Series, sample_size: int = 100) -> str |
None:
Review Comment:
love the idea of factoring this out. Given that `superset/utils/core.py` is
massive already, I'm wondering where it would best fit, maybe somewhere under
`superset/utils/`, I see there's a lot of pandas-helpers in
`superset/utils/pandas_postprocessing`, maybe could go there or maybe a new
`superset/utils/pandas.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
