Gordonei opened a new pull request, #35041: URL: https://github.com/apache/superset/pull/35041
(cherry picked from commit 2233c02720f30e01198e2e8a1367902d29c59729) ### SUMMARY This small PR just back ports the change described in https://github.com/apache/superset/pull/33107 to `4.1` branch ### TESTING INSTRUCTIONS When `4.1.x` worker with playwright enable screenshots an empty dashboard or a slice without a graph: ``` ``` [2025-09-05 06:27:29,501: ERROR/ForkPoolWorker-6] Timed out requesting url https://<redacted>/superset/slice/3129/?standalone=true Traceback (most recent call last): File "/app/superset/utils/webdriver.py", line 182, in get_screenshot element.wait_for() File "/usr/local/lib/python3.10/site-packages/playwright/sync_api/_generated.py", line 17975, in wait_for self._sync(self._impl_obj.wait_for(timeout=timeout, state=state)) File "/usr/local/lib/python3.10/site-packages/playwright/_impl/_sync_base.py", line 115, in _sync return task.result() File "/usr/local/lib/python3.10/site-packages/playwright/_impl/_locator.py", line 692, in wait_for await self._frame.wait_for_selector( File "/usr/local/lib/python3.10/site-packages/playwright/_impl/_frame.py", line 369, in wait_for_selector await self._channel.send( File "/usr/local/lib/python3.10/site-packages/playwright/_impl/_connection.py", line 69, in send return await self._connection.wrap_api_call( File "/usr/local/lib/python3.10/site-packages/playwright/_impl/_connection.py", line 558, in wrap_api_call raise rewrite_error(error, f"{parsed_st['apiName']}: {error}") from None playwright._impl._errors.TimeoutError: Locator.wait_for: Timeout 120000ms exceeded. Call log: - waiting for locator(".chart-container") to be visible ``` ### ADDITIONAL INFORMATION - [X] Has associated issue: https://github.com/apache/superset/issues/33132 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
