sadpandajoe commented on code in PR #34995:
URL: https://github.com/apache/superset/pull/34995#discussion_r2320931048
##########
superset-frontend/src/features/alerts/AlertReportModal.test.tsx:
##########
@@ -93,8 +93,9 @@ const generateMockPayload = (dashboard = true) => {
...mockPayload,
chart: {
id: 1,
- slice_name: 'Test Chart',
- viz_type: VizType.Table,
+ slice_name: 'test chart',
+ viz_type: 'table',
+ value: 1,
},
Review Comment:
- Looking at line 170 in validAlert, the label IS provided where needed
- The generateMockPayload function doesn't need label for all use cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
