sadpandajoe opened a new pull request, #34995: URL: https://github.com/apache/superset/pull/34995
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Noticed when forking off of master there are 2 test failures that show up that don't show up here. This will fix those tests for everyone. Fixes two failing tests in AlertReportModal.test.tsx: - "renders 5 checkmarks for a valid alert" (expected 5, received 3) - "does not show screenshot width when csv is selected" (couldn't find "test chart" text) Root cause analysis revealed three interconnected issues: 1. **Icon accessibility bug**: BaseIcon genAriaLabel function produced incorrect aria-labels due to regex split creating empty strings ("CheckCircleOutlined" → [""," Check","Circle","Outlined"] → "-check" instead of "check-circle") 2. **Incomplete test data**: validAlert mock was missing required validation fields for AlertReportModal's 5 validation sections (database, sql, validator_config_json, working_timeout, chart objects) 3. **Data structure mismatch**: Test mock used MetaObject format but AlertReportModal's data processing pipeline expected fallback domain object properties (slice_name, database_name) when getChartData/getDatabaseData return null **Solution:** - Fixed BaseIcon genAriaLabel to filter empty strings from regex split - Added complete validation data for all 5 AlertReportModal sections - Created hybrid test objects with both MetaObject and domain properties - Ensured proper chart_id/chart.id alignment for validation consistency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
