yousoph commented on PR #34607:
URL: https://github.com/apache/superset/pull/34607#issuecomment-3232465663
Bugs:
1. On dashboards, when the dashboard filter has a space in it, setting
`?f=('Country Code'=USA)` with the quotes and the space didn't successfully
match the dashboard filter that already exists
2. Unable to set two values for a filter on dashboards. I tried
`?f=(country:USA,Canada)` and `?f=(country:USA,country:Canada)` and neither set
the country filter to have both USA and Canada filter values
3. Unable to set dashboard filters for a numerical range filter. I tried
using this syntax: `?f=(msrp:(between:\!(35,200)))`
Improvements:
1. On dashboards, when the filter parameter in the URL matches an existing
dashboard setting, the "URL Filters" does not need to be displayed in the
Dashboard Filter Bar
2. On both charts and dashboards, it would be best if the filters were
already applied when the user loads the chart. Currently, the filters are set
but the "Apply filters" or "Update chart" button needs to be clicked before the
filters are visible in the chart or dashboard
4. On dashboards, when a filter doesn't exist as a dashboard filter and is
applied as a URL filter, we should use the same visual pattern as we do for
cross filters. This means:
a. The filter bar section for URL filters should match the cross filters
section visually. The section should be collapsible and each filter should have
a chip that can be removed from the UI
b. When there are URL filters applied, the filter icon on the charts
should have a section for URL filters
c. The order of the sections in the filter bar and the filter icon hover
tooltip should be: URL filters, cross filters, dashboard filters
5. If the user doesn’t have permission to set the URL filters, show them an
error on the dashboard so they are aware that the filters were not set
properly. This should probably show in the URL filters section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
