sadpandajoe opened a new pull request, #34864: URL: https://github.com/apache/superset/pull/34864
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY - Fixes browser crashes in headless Chrome 139 when using bulk delete operations - Removes deprecated `event.persist()` call that's unnecessary in React 17 - Adds comprehensive test suite with TypeScript conversion #### Background The ConfirmStatusChange component was causing 100% reproducible crashes in headless Chrome 139 during bulk delete operations across 14+ list components (ChartList, DashboardList, DatasetList, etc.). Root cause: The component used `event.persist()` from 2020 code, but React 17 doesn't require event persistence as events are no longer pooled. This deprecated pattern crashes modern headless Chrome. ### Changes Made **Component Fix** - **Remove `event.persist()` call** - Unnecessary in React 17+, causes crashes - **Keep `preventDefault` and `stopPropagation`** - Still needed for proper event handling 🤖 Generated with [Claude Code](https://claude.ai/code) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
