sadpandajoe commented on code in PR #34809:
URL: https://github.com/apache/superset/pull/34809#discussion_r2292792454
##########
superset-frontend/packages/superset-ui-core/src/components/Icons/AsyncIcon.tsx:
##########
@@ -46,6 +47,11 @@ const AsyncIcon = (props: IconType) => {
return (
<BaseIconComponent
component={ImportedSVG.current || TransparentIcon}
+ fileName={fileName}
+ customIcons={customIcons}
+ iconSize={iconSize}
+ iconColor={iconColor}
+ viewBox={viewBox}
{...restProps}
/>
Review Comment:
This is not duplicate spreading - we're destructuring specific props and
then passing them explicitly along with the remaining props. This is the
correct pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
