Vitor-Avila opened a new pull request, #34782: URL: https://github.com/apache/superset/pull/34782
### SUMMARY When generating an export, Superset would add the asset ID to the chart and dashboard file names, however for datasets it would use only the dataset name. This is problematic because it's possible to have multiple datasets with the same name as long as they have a different schema, catalog, or are from a different DB connection. As a result, if two datasets with the same name are exported, only one (likely the last one to be generated) is included in the ZIP file. This PR fixes this issue by adding the dataset ID to the file name (which is already the case for dashboards and charts). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI changes. ### TESTING INSTRUCTIONS 1. Make sure you have 2 DB connections. 2. Access SQL lab and create two virtual datasets using `select 1 as one` with the same name (one from each DB connection). 3. Access the **Datasets** menu and export both datasets via the bulk export. 4. Confirm both datasets are present in the ZIP file. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
