Re: [PR] feat(Timeseries & MixedTimeseries): Added configurability to value labels in Timeseries and Mixed Timeseries charts. Can rotate and set render distance of value labels [superset]

Wed, 06 Aug 2025 23:48:51 -0700 


korbit-ai[bot] commented on code in PR #34589:
URL: https://github.com/apache/superset/pull/34589#discussion_r2259255650


##########
superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx:
##########
@@ -163,13 +198,17 @@ export const percentageThresholdControl: ControlSetItem = 
{
 
 export const showValueSection: ControlSetRow[] = [
   [showValueControl],
+  [distanceValueControl],
+  [rotateValueControl],
   [stackControl],
   [onlyTotalControl],
   [percentageThresholdControl],
 ];
 
 export const showValueSectionWithoutStack: ControlSetRow[] = [
   [showValueControl],
+  [distanceValueControl],
+  [rotateValueControl],
   [onlyTotalControl],
 ];

Review Comment:
   ### Duplicated Value Section Controls <sub>![category 
Design](https://img.shields.io/badge/Design-0d9488)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   There is code duplication between showValueSection and 
showValueSectionWithoutStack where the value-related controls are repeated.
   
   
   ###### Why this matters
   Code duplication violates the DRY principle and makes maintenance more 
difficult as changes need to be made in multiple places.
   
   ###### Suggested change ∙ *Feature Preview*
   Extract common controls into a shared array and compose the sections:
   ```typescript
   const commonValueControls = [
     [showValueControl],
     [distanceValueControl],
     [rotateValueControl],
   ];
   
   export const showValueSection = [
     ...commonValueControls,
     [stackControl],
     [onlyTotalControl],
     [percentageThresholdControl],
   ];
   
   export const showValueSectionWithoutStack = [
     ...commonValueControls,
     [onlyTotalControl],
   ];
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4d8d68f9-7516-4f22-a7b4-3a50c834de59/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4d8d68f9-7516-4f22-a7b4-3a50c834de59?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4d8d68f9-7516-4f22-a7b4-3a50c834de59?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4d8d68f9-7516-4f22-a7b4-3a50c834de59?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4d8d68f9-7516-4f22-a7b4-3a50c834de59)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:d36aa9b9-8439-4314-9231-80704bb92cfe -->
   
   
   [](d36aa9b9-8439-4314-9231-80704bb92cfe)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to