dosubot[bot] commented on issue #34566: URL: https://github.com/apache/superset/issues/34566#issuecomment-3156654356
<!-- Answer --> This happens because the icon in a disabled button doesn't automatically inherit the muted/greyed-out color like the text does. Superset's Button component wraps AntdButton and passes the disabled prop, but the icon (rendered by BaseIconComponent) uses its own color logic and doesn't adjust based on the button's disabled state. There are currently no CSS rules in the codebase to ensure icons inside disabled buttons are visually muted, so icons keep their primary color until hover or other CSS events trigger a style change. This is why you see the difference between text-only and icon+text buttons when disabled. A fix would likely involve adding a CSS rule targeting icons inside disabled buttons or updating the icon component to check for the disabled state and apply the correct color. [Button implementation](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx) [BaseIconComponent implementation](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/packages/superset-ui-core/src/components/Icons/BaseIcon.tsx) <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/105fffad-c921-48f0-863c-cc8c8bfac940?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/105fffad-c921-48f0-863c-cc8c8bfac940?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/105fffad-c921-48f0-863c-cc8c8bfac940?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/105fffad-c921-48f0-863c-cc8c8bfac940?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/105fffad-c921-48f0-863c-cc8c8bfac940?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/105fffad-c921-48f0-863c-cc8c8bfac940?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/105fffad-c921-48f0-863c-cc8c8bfac940?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu b) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34566) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
