msyavuz commented on code in PR #34536:
URL: https://github.com/apache/superset/pull/34536#discussion_r2255210664
##########
superset-frontend/packages/superset-ui-core/src/components/ThemeSubMenu/index.tsx:
##########
@@ -71,13 +36,13 @@ export interface ThemeSubMenuProps {
allowOSPreference?: boolean;
}
-export const ThemeSubMenu: React.FC<ThemeSubMenuProps> = ({
+export const useThemeMenuItems = ({
Review Comment:
This is not the single instance, there are things like `useShareMenuItems`
`useHeaderActionsDropdown` `useDrillDetailMenuItems` `useDownloadMenuItems`. I
don't think putting single use hooks into ui-core is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
