Vitor-Avila commented on code in PR #34319:
URL: https://github.com/apache/superset/pull/34319#discussion_r2253072552
##########
superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx:
##########
@@ -151,6 +166,75 @@ const ChartContextMenu = (
canDrillBy &&
isDisplayed(ContextMenuItem.DrillBy);
+ useEffect(() => {
+ async function fetchDataset() {
+ if (!visible || dataset || (!showDrillBy && !showDrillToDetail)) return;
+
+ const datasetId = Number(formData.datasource.split('__')[0]);
+ try {
+ setIsLoadingDataset(true);
+ let response;
+
+ if (loadDrillByOptionsExtension) {
+ response = await loadDrillByOptionsExtension(datasetId, formData);
+ } else {
+ const endpoint =
`/api/v1/dataset/${datasetId}/drill_info/?q=(dashboard_id:${dashboardId})`;
+ response = await cachedSupersetGet({ endpoint });
+ }
+
+ const { json } = response;
+ const { result } = json;
+
+ setDataset(result);
+ } catch (error) {
+ logging.error('Failed to load dataset:', error);
+ supersetGetCache.delete(`/api/v1/dataset/${datasetId}/drill_info/`);
+ } finally {
+ setIsLoadingDataset(false);
+ }
+ }
+
+ fetchDataset();
+ }, [
+ visible,
Review Comment:
I've thought so too and checked with Claude and it advised not to, because
this block also does `setDataset(result)` so if `dataset` was a dependency it
would re-render one more time as the `dataset` value would change with
`setDataset(result)`.
From my manual tests it's working properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
