betodealmeida commented on code in PR #34388:
URL: https://github.com/apache/superset/pull/34388#discussion_r2252537110
##########
superset/commands/database/create.py:
##########
@@ -118,25 +111,23 @@ def run(self) -> Model:
) as ex:
event_logger.log_with_context(
action=f"db_creation_failed.{ex.__class__.__name__}",
- engine=database.db_engine_spec.__name__,
Review Comment:
Here `database` can be undefined, raising an exception inside the catch
block. Instead I compute the engine from the URI, and pass it to all instances
where we log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
