payose opened a new pull request, #34300: URL: https://github.com/apache/superset/pull/34300
SUMMARY This PR fixes a bug where the column names in an aggregated Table chart get displayed in the wrong order after changing the layout, especially when the Time Comparison feature is enabled. The issue was causing column headers to become misaligned or overlapped, leading to confusion when interpreting the data. Design decisions: Introduced logic to consistently map metric columns and time comparison columns in the correct order during layout updates. Ensured the internal data structure reflects the original metric ordering regardless of layout toggles. BEFORE/AFTER SCREENSHOTS Before: <img width="1084" height="403" alt="image" src="https://github.com/user-attachments/assets/e187a613-25be-45cc-aa1f-022530b6b4ca"; /> Column names appear in the wrong order or overlapped after layout change. After: <img width="2178" height="944" alt="image" src="https://github.com/user-attachments/assets/1a847122-eb95-4d62-aefb-dfc45f6195b1"; /> Column names remain consistent and correctly ordered even after changing the layout. TESTING INSTRUCTIONS - [ ] Create a Table chart with aggregated data and multiple metrics. - [ ] Assign a date filter interval. - [ ] Enable the Time Comparison feature (e.g., “Previous period” or “1 year ago”). - [ ] Add the chart to a dashboard. - [ ] Use the dashboard layout editor to hide/show comparison columns. - [ ] Verify that the column names remain correctly ordered and are not overlapping. ADDITIONAL INFORMATION Has associated issue: Fixes #34134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
