msyavuz commented on code in PR #34182:
URL: https://github.com/apache/superset/pull/34182#discussion_r2226295894
##########
.gitignore:
##########
@@ -131,3 +131,4 @@ superset/static/stats/statistics.html
# LLM-related
CLAUDE.local.md
.aider*
+CLAUDE.local.md
Review Comment:
```suggestion
```
seems like a duplicate
##########
superset-frontend/src/theme/ThemeController.ts:
##########
@@ -406,6 +574,17 @@ export class ThemeController {
* @returns The theme configuration for the specified mode or null if not
available
*/
private getThemeForMode(mode: ThemeMode): AnyThemeConfig | null {
+ // Priority 1: Dev theme override (highest priority for development)
+ // Dev overrides affect all contexts
+ if (this.devThemeOverride) {
+ return this.devThemeOverride;
+ }
+
+ // Priority 2: CRUD theme (organizational themes)
+ // CRUD themes should NEVER affect the mode-based theme selection
+ // Dashboard themes are handled separately via createDashboardThemeProvider
Review Comment:
Missing implementation
##########
superset-frontend/src/components/ListView/Filters/Search.tsx:
##########
@@ -43,9 +43,7 @@ interface SearchHeaderProps extends BaseFilter {
toolTipDescription: string | undefined;
}
-const StyledInput = styled(Input)`
- border-radius: ${({ theme }) => theme.borderRadius}px;
-`;
+// Using vanilla antd Input to avoid styled component circular dependency issue
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
