mistercrunch commented on code in PR #34193:
URL: https://github.com/apache/superset/pull/34193#discussion_r2211942284
##########
superset-frontend/src/dashboard/components/Header/index.jsx:
##########
@@ -415,7 +415,9 @@ const Header = () => {
owners: dashboardInfo.owners,
roles: dashboardInfo.roles,
slug,
- tags: dashboardInfo.tags,
+ tags: (dashboardInfo.tags || []).filter(
+ item => item.type === 1 || !item.type,
Review Comment:
do we have some sort of enum/constant anywhere on the frontend that properly
labels what TagType == 1 means?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
