Re: [PR] fix: dataset endpoint `/rowlevelsecurity/related/tables` doesn't apply filters as expected [superset]

Wed, 16 Jul 2025 12:29:14 -0700 


korbit-ai[bot] commented on code in PR #34192:
URL: https://github.com/apache/superset/pull/34192#discussion_r2211366781


##########
superset/views/filters.py:
##########
@@ -102,3 +102,22 @@ def apply(self, query: Query, value: Optional[Any]) -> 
Query:
             return extra_filters(query)
 
         return query
+
+
+class FilterRelatedTables(BaseFilter):  # pylint: 
disable=too-few-public-methods
+    """
+    A filter to allow searching for related tables.
+    Use in the api by adding something like:
+    related_field_filters = {
+      "tables": RelatedFieldFilter("table_name", FilterRelatedTables),
+    }
+    """
+
+    name = lazy_gettext("Table")
+    arg_name = "tables"
+
+    def apply(self, query: Query, value: Optional[Any]) -> Query:
+        from superset.connectors.sqla.models import SqlaTable

Review Comment:
   ### Local Import Anti-pattern <sub>![category 
Design](https://img.shields.io/badge/Design-0d9488)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Import statement is placed inside a method instead of at the module level, 
violating Python's import style guidelines and creating potential circular 
import issues.
   
   
   ###### Why this matters
   Local imports can hide dependencies, make code harder to understand, and 
potentially impact performance due to repeated imports. They should only be 
used when absolutely necessary to avoid circular dependencies.
   
   ###### Suggested change ∙ *Feature Preview*
   Move the import statement to the top of the file with other imports:
   ```python
   from superset.connectors.sqla.models import SqlaTable
   
   class FilterRelatedTables(BaseFilter):
       ...
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/43ae51da-f552-45b0-848b-69886b6f815d/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/43ae51da-f552-45b0-848b-69886b6f815d?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/43ae51da-f552-45b0-848b-69886b6f815d?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/43ae51da-f552-45b0-848b-69886b6f815d?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/43ae51da-f552-45b0-848b-69886b6f815d)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:1658ad19-e029-4db6-b46c-8588e2dd53d8 -->
   
   
   [](1658ad19-e029-4db6-b46c-8588e2dd53d8)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to