sadpandajoe commented on code in PR #34160:
URL: https://github.com/apache/superset/pull/34160#discussion_r2205582569
##########
superset-frontend/src/SqlLab/components/SaveQuery/index.tsx:
##########
@@ -215,7 +214,15 @@ const SaveQuery = ({
onHide={() => setShowSaveDatasetModal(false)}
buttonTextOnSave={t('Save & Explore')}
buttonTextOnOverwrite={t('Overwrite & Explore')}
- datasource={getDatasourceAsSaveableDataset(query)}
+ datasource={{
Review Comment:
why did we remove `getDatasourceAsSaveableDataset` when we updated the
definition below to be the same? Shouldn't we just keep it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
