justinpark opened a new pull request, #34129:
URL: https://github.com/apache/superset/pull/34129

   ### SUMMARY
   Due to patch #32679  in Superset version 5.0, there is an issue where 
previously, for datasets restricted by permissions, the dataset name would be 
displayed but the results were not allowed. With the recent changes, these are 
now shown as “missing dataset,” which leads to the system recognizing that 
there are no existing charts, even when they actually exist.
   
   |Before (4.1)|After (5.0)|
   |--|--|
   |<img width="1037" height="846" alt="Screenshot_2025-07-10_at_4_34_40 PM" 
src="https://github.com/user-attachments/assets/14a7d6fd-b250-44fa-86ff-9aa6d718f435";
 />|<img width="666" height="728" alt="Screenshot 2025-07-10 at 3 41 00 PM" 
src="https://github.com/user-attachments/assets/73dac316-662f-4baf-b73d-f751f4643741";
 />|
   
   This commit addresses this issue by adding handling for the 
SupersetSecurityException caused by #32679. Additionally, it improves the UI by 
displaying both the dataset name and the error message, making it easier to 
identify the cause when this issue occurs.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   After:
   
   <img width="749" height="602" alt="Screenshot 2025-07-10 at 3 40 50 PM" 
src="https://github.com/user-attachments/assets/a2e23c8d-1d7c-4913-8c5e-b33b529db3cc";
 />
   
   
   ### TESTING INSTRUCTIONS
   
   Create a dataset using a table permission doesn't exist
   Click a explore link to check the error message
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to