Re: [PR] fix: improve login page placement and width [superset]

Tue, 08 Jul 2025 17:27:52 -0700 


korbit-ai[bot] commented on code in PR #34108:
URL: https://github.com/apache/superset/pull/34108#discussion_r2193659577


##########
superset-frontend/src/pages/Login/index.tsx:
##########
@@ -57,8 +57,10 @@ enum AuthType {
 
 const StyledCard = styled(Card)`
   ${({ theme }) => css`
-    width: 40%;
+    max-width: 400px;
+    width: 100%;
     margin-top: ${theme.marginXL}px;
+    color: ${theme.colorBgContainer};

Review Comment:
   ### Incorrect Theme Token Usage <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Using theme.colorBgContainer for text color is incorrect as this token is 
meant for background colors.
   
   
   ###### Why this matters
   This will likely result in poor text visibility or contrast issues as 
background color tokens are being used for text content.
   
   ###### Suggested change ∙ *Feature Preview*
   Use the appropriate text color token `theme.colorText` instead:
   ```typescript
   color: ${theme.colorText};
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/68f5520a-a748-4748-a07b-ad2457208620/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/68f5520a-a748-4748-a07b-ad2457208620?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/68f5520a-a748-4748-a07b-ad2457208620?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/68f5520a-a748-4748-a07b-ad2457208620?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/68f5520a-a748-4748-a07b-ad2457208620)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:79869a6e-f78a-4bc8-8930-ca6b9bc4cd90 -->
   
   
   [](79869a6e-f78a-4bc8-8930-ca6b9bc4cd90)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to