Vitor-Avila commented on PR #31646: URL: https://github.com/apache/superset/pull/31646#issuecomment-2982296651
hey @ERGO1995 @rusackas @mistercrunch I think this is a super nice addition to the tool!!! I definitely don't want to drastically change the direction here (or increase complexity) but I was wondering if maybe instead of having this handled through a URL parameter, if this could be taken from a user property? If we think about Superset (non embedded context) currently the translation setting is "global" (not per account). If we were to have that set on the account level, then this would be dynamic/automatic for logged-in users, and then perhaps the approach to make it work with embedded would be to add a new key to the guest token payload that specifies the guest user language? I'm not against the URL param approach, but I think we'll eventually get to the point where Superset has per-user language, so I'm wondering if we want to tackle this problem for both logged in and embedded. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
