hzxa21 opened a new pull request, #33764: URL: https://github.com/apache/superset/pull/33764
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Prior to this PR, when user choose RisingWave as the db engine, it will display `postgresql://...` as the sqlalchemy uri placeholder. However, this may cause issues when browsing the dataset because there are unsupported functionalities. Based on the official [doc](https://superset.apache.org/docs/configuration/databases/#risingwave), `risingwave:://...` should be used so that [sqlalchemy-risingwave](https://pypi.org/project/sqlalchemy-risingwave/#history) will be chosen to be the driver. This PR modifies the sqlalchemy_uri_placeholder for RisingWave engine and adds optional dependency for risingwave in `pyproject.toml` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
