Vitor-Avila opened a new pull request, #33693:
URL: https://github.com/apache/superset/pull/33693

   ### SUMMARY
   In https://github.com/apache/superset/pull/33626, we decided to store the 
dataset's `changed_on` attribute in UTC, to ensure consistency. This introduced 
an issue to calculate the `changed_on_humanized` property (`now - 
item.changed_on`). In order to fix this calculation for new edits, we would 
have to update it to `now.utc() - item.changed_on` which then would break the 
calculation for items that were modified before this modification.
   
   Ideally, a long-term solution would be to implement timezone support at the 
DB level, and then migrate existing columns to use the timezone from the 
server. This however is not aligned with 
https://github.com/apache/superset/pull/33626 original's scope, so this PR just 
reverts that to store the `changed_on` using `now()`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   No UI changes.
   
   ### TESTING INSTRUCTIONS
   N/A.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to