mistercrunch commented on code in PR #33364:
URL: https://github.com/apache/superset/pull/33364#discussion_r2078587538


##########
superset/viz.py:
##########
@@ -1532,7 +1532,31 @@ def get_data(self, df: pd.DataFrame) -> VizData:
 
         slice_ids = self.form_data.get("deck_slices")
         slices = db.session.query(Slice).filter(Slice.id.in_(slice_ids)).all()
+
+        features: dict[str, list[Any]] = {}

Review Comment:
   Given this, it might inform doing this in JS if that's possible, and 
possibly hitting `/api/chart/data` N times (for each chart), and joining the 
data client-side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to