amaannawab923 commented on PR #33242:
URL: https://github.com/apache/superset/pull/33242#issuecomment-2834799246
> > Thanks for this contribution @amaannawab923! The main concern in the sip
was that we should stay close to the antd library. @michael-s-molina and @geido
does this design line up with antd? I did a quick look through and saw a fair
amount of css so not sure what your thoughts are.
>
> This seems to be a semi-custom implementation. Curious @amaannawab923 what
drove the customization decision VS going with what Ant Design provides and
build on top of that?
Thanks for the review @eschutho @geido , i tried to address all of the
concerns that were part of sip discussion , and i tried to address all of the
concerns mentioned in the discussion , even in the earlier version of time
filter plugin, we were using basic antd components like Select, Icons & Buttons
and building on top of that & i have kept the same consistency here with
import { Tabs, Button, Input, Radio } from 'antd';
these components from ant design...
I tried to take control over all of the css as per the discussion to address
the End user concerns of simplified ui & this custom Implementation doesnt use
any extra libraries ... Still relies on ant design for its core components but
with custom css on top of ant design i am able to control the component better
& make it more beautiful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
