Re: [PR] fix(chart): Restore subheader used in bignumber with trendline [superset]

Thu, 24 Apr 2025 00:45:06 -0700 


LevisNgigi commented on PR #33196:
URL: https://github.com/apache/superset/pull/33196#issuecomment-2826678724

   > @LevisNgigi my last comment was longer just to highlight the testing 
scenarios and flows, but to summarize, these are the remaining issues:
   > 
   > * Big Numbers created prior to [the `subtitle` 
PR](https://github.com/apache/superset/pull/32975) show the subheader text 
duplicated.
   > * Accessing the chart directly in Explore does not carry over the 
`subtitle` config (both text and size).
   > 
   > To easily repro this:
   > 
   > 1. Spin up Superset in dev mode.
   > 2. Check out to commit `164a07e2be7854520070a7d845eec449405c4840`.
   > 3. Create a dashboard including one Big Number for each subheader size 
available. For example:
   > 
   > <img alt="image" width="1783" 
src="https://private-user-images.githubusercontent.com/96086495/436838002-16d1b0ac-9d91-4356-b6de-a83fef5b7b52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU0ODA0MTUsIm5iZiI6MTc0NTQ4MDExNSwicGF0aCI6Ii85NjA4NjQ5NS80MzY4MzgwMDItMTZkMWIwYWMtOWQ5MS00MzU2LWI2ZGUtYTgzZmVmNWI3YjUyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDA3MzUxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVmOTRhYmIwZmY5ZjI4MTgzZWM1YTVkZDk2Y2UwZjllM2MxMDk2YTIxODM3ZTg3NDdmYmM3NWM2ZTczODJiOGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.o0yEhkornRTOWL49_MEJI6Gd-62_12aryubNuK1fOkg";>
 4. Checkout to this branch. 5. Refresh the dashboard: <img alt="image" 
width="1789" 
src="https://private-user-images.githubusercontent.com/96086495/436838184-f757f08b-43f9-4a21-
 
82ae-6c5572030e50.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU0ODA0MTUsIm5iZiI6MTc0NTQ4MDExNSwicGF0aCI6Ii85NjA4NjQ5NS80MzY4MzgxODQtZjc1N2YwOGItNDNmOS00YTIxLTgyYWUtNmM1NTcyMDMwZTUwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDA3MzUxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3ZjdjNmE3YzIyOWJkZmNiOTVhNTFkMWY0Y2FiMmM0ZjI2NzgwM2ZhNzUyZjM5NjY2YTEwNGRmZGY1NDY0N2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.igBqMBUg4sS8s6l5T8BdyMvzu6basPaf0a3Z-HTFHRE">
 6. Accessing a chart from this dashboard does not show the subtitle config: 
<img alt="image" width="1331" 
src="https://private-user-images.githubusercontent.com/96086495/436838276-9f138c6d-49c1-4a5f-bba1-00e4806e5aa5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3Lm
 
dpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU0ODA0MTUsIm5iZiI6MTc0NTQ4MDExNSwicGF0aCI6Ii85NjA4NjQ5NS80MzY4MzgyNzYtOWYxMzhjNmQtNDljMS00YTVmLWJiYTEtMDBlNDgwNmU1YWE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDA3MzUxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFlMjViM2FiYjNlZDI1YzJlY2UzZTIyY2FhMTU1NGUxOTc2MTQ1NmMwNWUzZDM0ZjFlNzlhYWI0Njg1ZWI3OGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wGcQ1ePmHtomW5wQ9ReRhrW4NuOeUzeusQV_B0aP834">
   > Let me know if you have any questions!
   
   @Vitor-Avila Thanks for the thorough testing and concise feedback with repro 
steps.The steps were super helpful! I’ve fixed the subtitle duplication issue 
for Big Number charts. However, the issue where legacy charts (those created 
with subheader only) don’t show the subtitle content or correct size in Explore 
is still pending. Mapping the control to subheader brings back the value in 
explore and configs are restored, but it prevents the subtitle from being fully 
clearable, which isn’t ideal.Since subheader is also used as the comparison 
suffix in Big Number with Trendline, a simple migration isn’t straightforward I 
think.So wondering the best way forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to