mistercrunch commented on code in PR #30134:
URL: https://github.com/apache/superset/pull/30134#discussion_r2038270948
##########
superset/views/dashboard/views.py:
##########
@@ -86,7 +85,11 @@ def new(self) -> FlaskResponse:
)
db.session.add(new_dashboard)
db.session.commit() # pylint: disable=consider-using-transaction
- return redirect(f"/superset/dashboard/{new_dashboard.id}/?edit=true")
+ return redirect(
+ url_for(
+ "Superset.dashboard", dashboard_id_or_slug=new_dashboard.id,
edit=True
Review Comment:
Somehow this line broke some tests on `master` but I don't understand how it
didn't get caught by CI (????).
Issues is with the capitalize `True` here... Maybe you IDE did this? Linter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
