amaannawab923 commented on code in PR #33054:
URL: https://github.com/apache/superset/pull/33054#discussion_r2037922865
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx:
##########
@@ -322,10 +383,35 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
loading={isRefreshing}
oneLine={filterBarOrientation === FilterBarOrientation.Horizontal}
invertSelection={inverseSelection}
+ showExcludeSelection={showExcludeSelection}
options={options}
sortComparator={sortComparator}
onDropdownVisibleChange={setFilterActive}
/>
+ {showExcludeSelection && (
+ <CheckBoxControlWrapper
+ className='exclude-filter'
+ onClick={() => handleExcludeCheckboxChange(!excludeFilterValues)}
+ data-test="exclude-filter-wrapper"
+ >
+ <Checkbox
+ dataTestAttribute="exclude-filter-checkbox"
+ checked={excludeFilterValues}
+ onChange={handleExcludeCheckboxChange}
+ />
+ <span data-test="exclude-filter-label">
+ {filterBarOrientation === FilterBarOrientation.Horizontal ?
t('Exclude Values') : t('Exclude Filter Values')}
+ </span>
+ <Tooltip
Review Comment:
<img width="1204" alt="Screenshot 2025-04-10 at 10 55 26 PM"
src="https://github.com/user-attachments/assets/f9da7424-f2d6-4d8e-9f8e-0ed3f59c74c7";
/>
Tried using it .... But its a different svg altogether that doesnt match the
shared designs ... The infotooltip svg has a single path whereas the one that
is required by designs belongs to the chart control panel which has 2 paths and
is able to take the correct color
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
