msyavuz commented on code in PR #33057:
URL: https://github.com/apache/superset/pull/33057#discussion_r2036996216
##########
superset-frontend/src/explore/components/controls/LayerConfigsControl/LayerConfigsPopoverContent.tsx:
##########
@@ -18,7 +18,8 @@
*/
import { css, JsonValue, styled, t } from '@superset-ui/core';
// eslint-disable-next-line no-restricted-imports
-import { Button, Form, Tabs } from 'antd'; // TODO: Remove antd
+import { Button, Form } from 'antd'; // TODO: Remove antd
Review Comment:
I think we missed these two imports while migrating
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -214,122 +214,126 @@ const ContourPopoverControl = ({
}
};
+ // Define tab items
Review Comment:
```suggestion
```
##########
superset-frontend/src/explore/components/controls/LayerConfigsControl/LayerConfigsPopoverContent.tsx:
##########
@@ -18,7 +18,8 @@
*/
import { css, JsonValue, styled, t } from '@superset-ui/core';
// eslint-disable-next-line no-restricted-imports
-import { Button, Form, Tabs } from 'antd'; // TODO: Remove antd
+import { Button, Form } from 'antd'; // TODO: Remove antd
Review Comment:
I think we missed these two imports
##########
superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.jsx:
##########
@@ -470,31 +473,31 @@ export default class AdhocMetricEditPopover extends
PureComponent {
</Tooltip>
) : (
t('Custom SQL')
- )
- }
- data-test="adhoc-metric-edit-tab#custom"
Review Comment:
is this not necessary anymore?
##########
superset-frontend/src/features/datasets/AddDataset/EditDataset/index.tsx:
##########
@@ -87,7 +87,13 @@ const EditPage = ({ id }: EditPageProps) => {
},
];
- return <StyledTabs moreIcon={null} items={items} />;
+ return (
+ <StyledTabs
+ moreIcon={null}
+ items={items}
+ tabBarStyle={{ paddingLeft: theme.sizeUnit * 4 }}
Review Comment:
if we are using the theme we should use useTheme instead
##########
superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx:
##########
@@ -310,10 +306,8 @@ class TabbedSqlEditors extends
PureComponent<TabbedSqlEditorsProps> {
/>
</Tooltip>
}
- >
- {editors}
- {noQueryEditors && emptyTabState}
- </StyledEditableTabs>
+ items={tabItems} // Use the dynamically generated items array
Review Comment:
```suggestion
items={tabItems}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
