fnardin-maystreet commented on code in PR #32995:
URL: https://github.com/apache/superset/pull/32995#discussion_r2031302949
##########
superset-frontend/src/components/Icons/BaseIcon.tsx:
##########
@@ -43,15 +43,27 @@ export const BaseIconComponent: React.FC<
iconSize,
viewBox,
customIcons,
+ disabled,
...rest
}) => {
const theme = useTheme();
+ // Some custom icons have a hardcoded fill color. Setting the color prop
+ // will not override it. In those cases, the fill color needs to be set
+ // directly on the path element inside the SVG.
+ // Examples: VizTitle.tsx (big_number_chart_tile.svg) and DragHandle.tsx
(drag.svg).
const iconCss = css`
color: ${iconColor || theme.colors.grayscale.base};
font-size: ${iconSize
? `${theme.typography.sizes[iconSize] || theme.typography.sizes.m}px`
: '24px'};
`;
+ const disabledIconCss = css`
+ opacity: 0.5;
+ cursor: default;
Review Comment:
updated to be fancy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
