rusackas commented on code in PR #32996:
URL: https://github.com/apache/superset/pull/32996#discussion_r2027149005
##########
superset-frontend/src/features/rls/RowLevelSecurityModal.tsx:
##########
@@ -102,6 +102,28 @@ const StyledTextArea = styled(TextArea)`
margin-top: ${({ theme }) => theme.gridUnit}px;
`;
+const StyledDropdownContainer = styled.div`
Review Comment:
This PR adds a lot of styled elements. Do you think that in support of
Theming efforts underway, we could either:
a) Just go with "vanilla" AntD components and minimize style overrides
b) Move these styles into the root component behind a new prop so that
they're reusable rather than bespoke for this one instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
